ci: Test all R versions on branches that start with cran- #540
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the GitHub Actions workflow to enable testing across all R versions for branches starting with "cran-". Previously, comprehensive R version testing (via the rcc-full job) was restricted to scheduled runs and manual workflow dispatches. Now, it will also run for:
- Push events to branches matching the
cran-*pattern - Pull requests from branches starting with "cran-" within the same repository
Changes:
- Updated the
versions-matrixstep condition to include PRs from branches starting with "cran-" - Simplified the
rcc-fulljob condition to run whenever the versions matrix is populated, rather than only on scheduled events or manual triggers
| # - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-" | ||
| # Do not run for: | ||
| # - workflow_dispatch if not requested | ||
| # Always run for other events. |
There was a problem hiding this comment.
The comment does not accurately describe the conditional logic. The comment states "pull requests if the base repo is different from the head repo and the branch name does not start with 'cran-'", but the code uses OR logic which means it will run when the branch name DOES start with "cran-".
The comment should be updated to accurately reflect that the versions-matrix step runs for:
- Pull requests when either the head repo is different from the base repo OR the branch starts with "cran-"
- Other events (with workflow_dispatch conditional on input)
| # - pull requests if the base repo is different from the head repo and the branch name does not start with "cran-" | |
| # Do not run for: | |
| # - workflow_dispatch if not requested | |
| # Always run for other events. | |
| # - pull requests when either the base repo is different from the head repo OR the branch name starts with "cran-" | |
| # - other events (except workflow_dispatch when not requested) | |
| # Do not run for: | |
| # - workflow_dispatch if not requested via inputs.versions-matrix |
No description provided.